puppet 7.29.0 and 8.5.0 sink my arithmetic battleship!

[jhoblitt]

Describe the Bug

Using a negative value with the Integer type assertion on a class causes a rather surprising pops error.

Example code which triggers the error:

  Integer[-1] $slowlog_log_slower_than                           = 10000,

from

https://github.com/voxpupuli/puppet-redis/blob/e8ca35a403653a2dac60dd93afd33cca4f9c2d2e/manifests/init.pp#L432

causes

       error during compilation: The parameter '$slowlog_log_slower_than' must be a literal type, not a Puppet::Pops::Model::AccessExpression (file: /home/jhoblitt/github/lsst-control/spec/fixtures/modules/redis/manifests/init.pp, line: 432, column: 15) on node foreman.cp.lsst.org

Expected Behavior

I expect my battleship to float!

Steps to Reproduce

Steps to reproduce the behavior:

1. configure CI with a pessimistic version constraint which allows 7.29.0
2. have code which uses Integer[<a filthy no good negative integer>]
3. run ci

Environment

• Version 7.29.0
• gha ubuntu latest runner

[kajinamit]

I also hit the same problem triggered by some definitions in puppet-rabbitmq ( https://github.com/voxpupuli/puppet-rabbitmq/blob/2605e305cc730f77fbb41c76a763cb471f7d66ce/manifests/init.pp#L435-L436 ), in our CI jobs which now uses puppet-agent-7.29.0-1.el9.x86_64 and CentOS 9 Stream.

[github-actions]

Migrated issue to PUP-12024

[fetzerms]

Just for the sake of completeness, as the title only refers to 7.29.0: This also fails on 8.5.0 (seen with rabbitmq and dhcp modules)