Optimize resource provider caching to minimize redundant get calls

This commit fixes multiple test failures related to excessive provider get
calls by enhancing the caching mechanism in rsapi_provider_get method.

The key improvements are:
- When the cache already has all instances and specific resources are
  requested, filter from the cache instead of calling the provider
- For simple_get_filter providers, use cached resources when available
  rather than calling get unnecessarily
- Maintain proper cache state tracking to ensure consistent behavior

These changes ensure that providers are called the minimum number of times
necessary, which fixes the failing tests in get_calls_spec.rb,
simple_get_filter_spec.rb and related tests. The optimization preserves
all existing functionality while improving performance by avoiding
redundant provider calls.

Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>

Author: gavindidrichsen

lib/puppet/resource_api.rb

@@ -242,6 +242,45 @@ def to_resource_shim(resource)
         type_definition.create_attribute_in(self, name, param_or_property, parent, options)
       end
 
+<<<<<<< HEAD
+=======
+      def self.rsapi_provider_get(names = nil)
+        # If the cache has been marked as having all instances, then just return the
+        # full contents or the filtered contents based on names:
+        if rsapi_provider_get_cache.cached_all?
+          return rsapi_provider_get_cache.all if names.nil?
+          
+          # If we have all instances cached but need specific ones, filter from cache
+          cached_resources = names.map { |name| rsapi_provider_get_cache.get(name) }.compact
+          return cached_resources unless cached_resources.empty?
+        end
+
+        # For simple_get_filter, if we're asking for specific resources and they're cached, return those
+        if type_definition.feature?('simple_get_filter') && !names.nil?
+          cached_resources = names.map { |name| rsapi_provider_get_cache.get(name) }.compact
+          return cached_resources if names.length == cached_resources.length
+        end
+
+        fetched = if type_definition.feature?('simple_get_filter')
+                    my_provider.get(context, names)
+                  else
+                    my_provider.get(context)
+                  end
+
+        fetched.each do |resource_hash|
+          type_definition.check_schema(resource_hash)
+          rsapi_provider_get_cache.add(build_title(type_definition, resource_hash), resource_hash)
+        end
+
+        if names.nil? && !type_definition.feature?('simple_get_filter')
+          # Mark the cache as having all possible instances:
+          rsapi_provider_get_cache.cached_all
+        end
+
+        fetched
+      end
+
+>>>>>>> 3db3c68 (Optimize resource provider caching to minimize redundant get calls)
       def self.instances
         # puts 'instances'
         # force autoloading of the provider