Skip to content

Release prep v4.2.4 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Release prep v4.2.4 #191

merged 1 commit into from
Feb 9, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 9, 2024

Automated release-prep from commit a59e682.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


GitHub Actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CHANGELOG.md Outdated
### Fixed

- (GH-189) - invalid fact correction for top scope structured fact [#190](https://github.com/puppetlabs/puppet-lint/pull/190) ([jordanbreen28](https://github.com/jordanbreen28))
- (CAT-1688) Upgrade Rubocop to `~> 1.50.0` [#185](https://github.com/puppetlabs/puppet-lint/pull/185) ([LukasAud](https://github.com/LukasAud))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if that should be listed under Fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah agreed, bit of a pain point with the changelog generator, if we label as maintenance it won't show on the changelog.
That being said, I do think the maintenance label is more appropriate in this case.

@jordanbreen28
Copy link

thank you @bastelfreak!

@jordanbreen28 jordanbreen28 merged commit 05af720 into main Feb 9, 2024
@jordanbreen28 jordanbreen28 deleted the release-prep branch February 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants