Skip to content

(CAT-1434) Update README #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023
Merged

(CAT-1434) Update README #156

merged 1 commit into from
Oct 2, 2023

Conversation

GSPatton
Copy link

@GSPatton GSPatton commented Oct 2, 2023

Removed outdated compatability warning since Puppet 6 is not supported by any tool. Added development section taken from https://github.com/puppetlabs/puppetlabs-concat#development detailing how users can run acceptance tests, raise PRs/Issues and contact support

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@GSPatton GSPatton requested review from bastelfreak and a team as code owners October 2, 2023 14:36
@GSPatton GSPatton force-pushed the CAT-1434-Update_readmne branch from 1a905bb to 8245365 Compare October 2, 2023 14:37
@@ -7,12 +7,6 @@
Puppet Lint tests Puppet code against the recommended [Puppet language style
guide](http://puppet.com/docs/puppet/latest/style_guide.html). Puppet Lint validates only code style; it does not validate syntax. To test syntax, use Puppet's `puppet parser validate` command.

## Compatibility warning
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful information. Please keep it in. Perhaps update it to make it clear it is current.

@@ -297,6 +291,18 @@ If you find a bug in Puppet Lint or its results, please create an issue in the
[repo issues tracker](https://github.com/puppetlabs/puppet-lint/issues/). Bonus
points will be awarded if you also include a patch that fixes the issue.

## Development

Acceptance tests for this tool leverage [puppet_litmus](https://github.com/puppetlabs/puppet_litmus).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really wish it didn't. Litmus an aweful tool for this and I wish #89 got a proper response for maintainers.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ekohl. I'll make a note of this and bring it to the team for discussion

@GSPatton GSPatton force-pushed the CAT-1434-Update_readmne branch 2 times, most recently from f994430 to 1129a34 Compare October 2, 2023 14:56
@GSPatton GSPatton force-pushed the CAT-1434-Update_readmne branch from 1129a34 to ebc4c92 Compare October 2, 2023 15:02
Updated outdated compatability warning since Puppet 6 is not supported by any tool.
Added development section taken from https://github.com/puppetlabs/puppetlabs-concat#development detailing how users can run acceptance tests, raise PRs/Issues and contact support
@GSPatton GSPatton force-pushed the CAT-1434-Update_readmne branch from ebc4c92 to 6ee8b17 Compare October 2, 2023 16:03
@jordanbreen28 jordanbreen28 merged commit febba03 into main Oct 2, 2023
@jordanbreen28 jordanbreen28 deleted the CAT-1434-Update_readmne branch October 2, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants