legacy_facts: Deal with variables ending in facts #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
fix-legacy-facts
branch
from
664969b to
24ecc3f
Compare
|
Rebase done. |
A reproducer for this from a real module: ```puppet $interface_facts = $facts['networking']['interfaces'][$foreman_proxy::dhcp_interface] $interface_facts['network'] ``` It also enhances the code to use a single regular expression, using back references and named capture groups.
ekohl
force-pushed
the
fix-legacy-facts
branch
from
24ecc3f to
2c50811
Compare
bastelfreak
approved these changes
Oct 3, 2023
|
And green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The whole fact name is now matched, instead of just a subset. It also enhances the code to use a single regular expression, using back references and named capture groups.
Additional Context
A reproducer for this from a real module:
Checklist