Merge pull request #147 from puppetlabs/revert-142-CAT-1301-add_unsafe_interpolations_check

Revert "(CAT-1301) Add check unsafe interpolations check"

Author: david22swan

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-08-25 10:33:19 UTC using RuboCop version 1.48.1.
+# on 2023-04-04 08:44:46 UTC using RuboCop version 1.48.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -34,12 +34,12 @@ Lint/MissingCopEnableDirective:
     - 'lib/puppet-lint/tasks/puppet-lint.rb'
     - 'spec/unit/puppet-lint/puppet-lint_spec.rb'
 
-# Offense count: 60
+# Offense count: 58
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 142
 
-# Offense count: 36
+# Offense count: 34
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
 # AllowedMethods: refine
 Metrics/BlockLength:
@@ -55,27 +55,22 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 387
 
-# Offense count: 35
+# Offense count: 33
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 33
 
-# Offense count: 82
+# Offense count: 80
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 108
 
-# Offense count: 27
+# Offense count: 26
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 31
 
-# Offense count: 1
-Naming/AccessorMethodName:
-  Exclude:
-    - 'lib/puppet-lint/plugins/check_unsafe_interpolations/check_unsafe_interpolations.rb'
-
-# Offense count: 186
+# Offense count: 182
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
@@ -97,13 +92,13 @@ Performance/CollectionLiteralInLoop:
     - 'lib/puppet-lint/plugins/check_resources/ensure_first_param.rb'
     - 'lib/puppet-lint/plugins/check_whitespace/trailing_whitespace.rb'
 
-# Offense count: 417
+# Offense count: 406
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 42
+# Offense count: 41
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Enabled: false
@@ -127,7 +122,7 @@ RSpec/FilePath:
     - 'spec/unit/puppet-lint/lexer_spec.rb'
     - 'spec/unit/puppet-lint/puppet-lint_spec.rb'
 
-# Offense count: 139
+# Offense count: 138
 RSpec/MultipleExpectations:
   Max: 137
 
@@ -141,21 +136,14 @@ RSpec/MultipleMemoizedHelpers:
 RSpec/NestedGroups:
   Max: 5
 
-# Offense count: 10
+# Offense count: 8
 RSpec/RepeatedExampleGroupDescription:
   Exclude:
     - 'spec/unit/puppet-lint/plugins/check_resources/file_mode_spec.rb'
     - 'spec/unit/puppet-lint/plugins/check_resources/unquoted_file_mode_spec.rb'
-    - 'spec/unit/puppet-lint/plugins/check_unsafe_interpolations/check_unsafe_interpolations_spec.rb'
     - 'spec/unit/puppet-lint/plugins/legacy_facts/legacy_facts_spec.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Style/ConcatArrayLiterals:
-  Exclude:
-    - 'lib/puppet-lint/plugins/check_unsafe_interpolations/check_unsafe_interpolations.rb'
-
-# Offense count: 108
+# Offense count: 106
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never