Set concurrency to 1 for auditor/replicator/updater

Before this the default concurrency was set to $::processorcount, and
this resulted in environments where 24 auditors/replicators/reapers
processes were all using the same disk. This results in a high I/O load,
because every thread blocks the others.

These values are 1 by default in Swift. If one has many disks and a
powerful machine, a single-digit concurrency for auditors and
replicators might work fine; the reaper is most likely only running with
a concurrency of 1 in any case.

Let's set this to the default of 1; operators with a need to use a
higher value can easily override the defaults (and probably want to use
a value that is appropriate to their setup).

Closes-Bug: 1631359
Change-Id: I54a5d01e4bd357973e142274db79d119e9e46457

Author: cschwede

manifests/storage/server.pp

@@ -66,15 +66,15 @@
 #
 # [*replicator_concurrency*]
 #   (optional) Number of replicator workers to spawn.
-#   Defaults to $::processorcount.
+#   Defaults to 1.
 #
 # [*updater_concurrency*]
 #   (optional) Number of updater workers to spawn.
-#   Defaults to $::processorcount.
+#   Defaults to 1.
 #
 # [*reaper_concurrency*]
 #   (optional) Number of reaper workers to spawn.
-#   Defaults to $::processorcount.
+#   Defaults to 1.
 #
 # [*log_facility*]
 #   (optional) Syslog log facility.
@@ -149,9 +149,9 @@
   $user                           = 'swift',
   $workers                        = '1',
   $allow_versions                 = false,
-  $replicator_concurrency         = $::processorcount,
-  $updater_concurrency            = $::processorcount,
-  $reaper_concurrency             = $::processorcount,
+  $replicator_concurrency         = 1,
+  $updater_concurrency            = 1,
+  $reaper_concurrency             = 1,
   $log_facility                   = 'LOG_LOCAL2',
   $log_level                      = 'INFO',
   $log_address                    = '/dev/log',

spec/defines/swift_storage_node_spec.rb

@@ -4,7 +4,6 @@
     OSDefaults.get_facts({
       :operatingsystem => 'Ubuntu',
       :osfamily        => 'Debian',
-      :processorcount  => 1,
     })
   end
 

spec/defines/swift_storage_server_spec.rb

@@ -5,7 +5,6 @@
     OSDefaults.get_facts({
       :operatingsystem => 'Ubuntu',
       :osfamily        => 'Debian',
-      :processorcount  => 1,
     })
   end