Skip to content

Commit 336ddc7

Browse files
authored
Merge pull request #2103 from pupil-labs/port-audio-macos-crash-fix
Workaround for Player crashing with OSError: [Errno -9986] Internal PortAudio error
2 parents a301e37 + 4f4b87d commit 336ddc7

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

pupil_src/shared_modules/audio_playback.py

+7-1
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,12 @@ def _setup_output_audio(self):
166166

167167
except ValueError:
168168
self.pa_stream = None
169+
except OSError:
170+
self.pa_stream = None
171+
import traceback
172+
173+
logger.warning("Audio found, but playback failed (#2103)")
174+
logger.debug(traceback.format_exc())
169175

170176
def _setup_audio_vis(self):
171177
self.audio_timeline = None
@@ -321,7 +327,7 @@ def update_audio_viz(self):
321327
self.audio_viz_data, finished = self.audio_viz_trans.get_data(
322328
log_scale=self.log_scale
323329
)
324-
if not finished:
330+
if not finished and self.audio_timeline:
325331
self.audio_timeline.refresh()
326332

327333
def setup_pyaudio_output_if_necessary(self):

0 commit comments

Comments
 (0)