Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Entra PIM custom resource #3663

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Azure Entra PIM custom resource #3663

wants to merge 10 commits into from

Conversation

thomas11
Copy link
Contributor

  • Don't require custom resources to implement Read to implement Create
  • WIP Custom resource for PIM role management policies (ARM, not AAD).
  • First working iteration in a local test. Some TODOs and missing tests.
  • Update with restoring deleted rules to their original state
  • Need to preserve the original state across updates
  • Complete e2e integration test for role management policies, with external validation via azure SDK
  • Make sure original state survives all roundtrips
  • regenerate

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • authorization.RoleManagementPolicy

New functions:

  • authorization.getRoleManagementPolicy

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 119 lines in your changes missing coverage. Please review.

Project coverage is 58.53%. Comparing base (ce90e01) to head (5cba82d).

Files with missing lines Patch % Lines
...ovider/pkg/resources/customresources/custom_pim.go 37.59% 76 Missing and 7 partials ⚠️
provider/pkg/provider/provider.go 36.36% 9 Missing and 5 partials ⚠️
provider/pkg/provider/crud/crud.go 0.00% 9 Missing ⚠️
provider/pkg/openapi/discover.go 0.00% 5 Missing and 1 partial ⚠️
...r/pkg/resources/customresources/customresources.go 62.50% 2 Missing and 1 partial ⚠️
...r/pkg/resources/customresources/custom_keyvault.go 0.00% 0 Missing and 2 partials ⚠️
...es/customresources/custom_keyvault_accesspolicy.go 0.00% 1 Missing ⚠️
...er/pkg/resources/customresources/custom_storage.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3663      +/-   ##
==========================================
- Coverage   59.07%   58.53%   -0.54%     
==========================================
  Files          70       71       +1     
  Lines       11102    11270     +168     
==========================================
+ Hits         6558     6597      +39     
- Misses       4041     4157     +116     
- Partials      503      516      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant