Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bender override issue #49

Open
meggiman opened this issue Jun 9, 2021 · 0 comments
Open

Bender override issue #49

meggiman opened this issue Jun 9, 2021 · 0 comments

Comments

@meggiman
Copy link

meggiman commented Jun 9, 2021

When using version override in a Bender.local file, Bender behaves inconsistent to a normal version declaration:
Let's assume the following Bender.yml file of a sub-dependency:

...
dependencies:
  foo: {git: "https://github.com/foo/foo.git", version: 0.3.0} # version 0.3.0 = commit-id "abcd"

and the following override file:

overrides:
  foo: {git: "https://github.com/foo/foo.git", rev: "1234"}

If we call bender update followed by bender path foo we get the following:

/......../.bender/git/checkouts/foo-abcd

Inspecting this directory reveals, that bender checked out commit 1234 within the foo-abcd directory. First of all, this is unintuitive because the user would expect bender to generate a new version directory like it does for any other (not overriden) dependency.
The second problem is: If commit 1234 does not exist, bender update will not error out but will just keep using commit version abcd without notifying the user about the non existent override version 1234.

Expected behavior: Bender should create new directories for override versions and show an error message if it cannot find the commit referenced in an override.

paulsc96 pushed a commit that referenced this issue Sep 10, 2022
Mark the variables declared by the `snitch_cluster` system software CMakeLists.txt as `CACHE`, to then be picked-up appropriately by the `SnitchUtilities.cmake` file later on. Otherwise the wrong simulator and runtime would be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant