Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flist and flist-plus documentation #177

Closed
colluca opened this issue Aug 6, 2024 · 3 comments
Closed

flist and flist-plus documentation #177

colluca opened this issue Aug 6, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@colluca
Copy link
Contributor

colluca commented Aug 6, 2024

Do I understand correctly, that the flist command outputs a whitespace-separated filelist (as could be used e.g. in Makefile prerequisites) and the flist-plus command now outputs what flist previously did as described in the README?

If so, I would open a PR to update the README accordingly.

@colluca colluca self-assigned this Aug 6, 2024
@colluca colluca added the enhancement New feature or request label Aug 6, 2024
@micprog
Copy link
Member

micprog commented Aug 6, 2024

So, with some review, the previous flist command generated a file list with +incdir+s, as illustrated here: https://github.com/pulp-platform/bender/blob/v0.27.4/src/cmd/script.rs#L707-L750

The current version only generates a file list, as far as I know separated with newlines (see https://github.com/pulp-platform/bender/blob/v0.28.1/src/script_fmt/flist.tera), while flist-plus generates a file list with +incdir+s and +define+s at the start, as illustrated in the new template format here: https://github.com/pulp-platform/bender/blob/v0.28.1/src/script_fmt/flist-plus.tera . Ultimately, the old format is a mix of the new formats, where the new formats are more clearly separated between a basic file list and a tool-ready file list.

Feel free to propose a PR, either modifying the command or modifying the readme.

@colluca
Copy link
Contributor Author

colluca commented Aug 6, 2024

Great, thanks :) Will open a PR to update the README.

@colluca
Copy link
Contributor Author

colluca commented Sep 26, 2024

Closing this as solved in #178.

@colluca colluca closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants