Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in vector widening floating-point arithmetic instructions: subnormal and special cases are not handled #221

Open
Shafi10x opened this issue Mar 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Shafi10x
Copy link
Contributor

Shafi10x commented Mar 15, 2023

In vector widening floating-point arithmetic instructions, the number is first converted to a double width format. It seems that during the conversion to double-width, implementation does not handle subnormal numbers and special cases. This could potentially lead to unexpected results or errors in certain computations that involve these special cases. Therefore, it's important to ensure that the conversion process includes proper handling of subnormal numbers and special cases.
Example:

If a number is zero in single-precision floating-point format, it should also be zero when converted to double-precision floating-point format but implementation changes the number zero.

@Shafi10x Shafi10x changed the title In vfwadd, subnormal numbers and zero are not handled Issue in vector widening floating-point arithmetic instructions: subnormal numbers and special cases are not handled Mar 31, 2023
@Shafi10x Shafi10x changed the title Issue in vector widening floating-point arithmetic instructions: subnormal numbers and special cases are not handled Issue in vector widening floating-point arithmetic instructions: subnormal and special cases are not handled Mar 31, 2023
@mp-17
Copy link
Collaborator

mp-17 commented Apr 17, 2023

Thanks @Shafi10x,

I will have a look at this! Very much appreciated!

@Shafi10x
Copy link
Contributor Author

Shafi10x commented Apr 17, 2023

@mp-17 Welcome, I have resolved the issue and have also created a PR for it, which can be viewed at #222. I kindly request you to take a look at it as well. Thank you!

@mp-17 mp-17 added the bug Something isn't working label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants