Bug fix Sling Reactive clearSubscription

* Bug fix Sling Reactive clearSubscription.
* Bump version to 20.3.1.
* Add automated test for Sling Reactive bringing the total to 198.

Author: puckowski

dist_sling/sling-reactive.min.js

@@ -629,7 +629,7 @@ var l = function l(_ref3) {
     }), t;
   };
 function version() {
-  return "20.3.0";
+  return "20.3.1";
 }
 var E = function E(t, e) {
     return t.split(e).length - 1;

dist_sling/sling.es5.js

@@ -1,6 +1,6 @@
 {
   "name": "sling.js",
-  "version": "20.3.0",
+  "version": "20.3.1",
   "description": "Client-side JavaScript framework for building Single Page Applications.",
   "main": "index.js",
   "scripts": {

dist_sling/sling.min.es5.js

@@ -13035,6 +13035,33 @@ export class GlobalTestRunner {
         window.globalTestCount++;
     }
 
+    testClearSubscriptionForSubjectWorks() {
+        const result = {
+            test: 'test clearSubscription for BehaviorSubject works',
+            success: false,
+            message: ''
+        };
+
+        const sub = BehaviorSubject(0);
+        let subscriberRuns = 0;
+        const subscriber = () => {
+            subscriberRuns++;
+        };
+        const subscriberToClear = () => {
+            return;
+        };
+        sub.subscribe(subscriber);
+        sub.subscribe(subscriberToClear);
+        sub.next(1);
+        sub.clearSubscription(subscriberToClear);
+        sub.next(2);
+
+        result.success = subscriberRuns === 2;
+
+        window.globalTestResults.push(result);
+        window.globalTestCount++;
+    }
+
     testAfterInitListExists() {
         const result = {
             test: 'test internal slAfterInit list exists',

dist_sling/sling.min.js

@@ -1115,7 +1115,7 @@ const _mountInternal = (target, component, attachDetector) => {
 }
 
 export function version() {
-    return '20.3.0';
+    return '20.3.1';
 }
 
 function xmur3(str) {

dist_sling/sling.min.nomodule.js

@@ -1047,7 +1047,7 @@ const _mountInternal = (target, component, attachDetector) => {
 }
 
 export function version() {
-    return '20.3.0';
+    return '20.3.1';
 }
 
 export function resolveAll(promiseArr) {

dist_sling/sling.slim.min.js

@@ -2,8 +2,8 @@ export const Observable = (array) => {
     const arrFns = ['pop', 'push', 'reverse', 'shift', 'unshift', 'splice', 'sort', 'map', 'filter', 'fill', 'copyWithin'];
     const noReturnFns = arrFns.slice(0, 6);
     const observeOps = {};
-    const subscribedFns = [];
-
+    
+    let subscribedFns = [];
     let data = array;
     let subCallCount = 0;
 
@@ -62,7 +62,7 @@ export const Observable = (array) => {
         const filteredFns = subscribedFns.filter(currFn => currFn !== fn);
         this.clearSubscriptions();
 
-        subscribedFns.concat(filteredFns);
+        subscribedFns = subscribedFns.concat(filteredFns);
 
         return this;
     }
@@ -89,8 +89,8 @@ export const Observable = (array) => {
 
 export const BehaviorSubject = (value) => {
     const subjectOps = {};
-    const subscribedFns = [];
-
+    
+    let subscribedFns = [];
     let data = value;
 
     const callCallback = function () {
@@ -110,7 +110,7 @@ export const BehaviorSubject = (value) => {
         const filteredFns = subscribedFns.filter(currFn => currFn !== fn);
         this.clearSubscriptions();
 
-        subscribedFns.concat(filteredFns);
+        subscribedFns = subscribedFns.concat(filteredFns);
 
         return this;
     }
@@ -146,8 +146,8 @@ export const Stream = () => {
     const dependentFns = [];
     const data = [];
     const streamOps = {};
-    const subscribedFns = [];
-
+    
+    let subscribedFns = [];
     let length = 0;
 
     const react = function () {
@@ -209,7 +209,7 @@ export const Stream = () => {
         const filteredFns = subscribedFns.filter(currFn => currFn !== fn);
         this.clearSubscriptions();
 
-        subscribedFns.concat(filteredFns);
+        subscribedFns = subscribedFns.concat(filteredFns);
 
         return this;
     }