Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not work with notebook files (*.ipynb) #16

Closed
venaturum opened this issue Jun 8, 2021 · 8 comments
Closed

Extension does not work with notebook files (*.ipynb) #16

venaturum opened this issue Jun 8, 2021 · 8 comments

Comments

@venaturum
Copy link

Looks like it may need to listen for event onDidSaveNotebookDocument ?

@pucelle
Copy link
Owner

pucelle commented Jun 16, 2021

Busy these days, will fix it soon.

@venaturum
Copy link
Author

I know the feeling 😆

Thanks!

@pucelle
Copy link
Owner

pucelle commented Jun 27, 2021

Hi, venaturum, I checked the new vscode API at: https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/vscode, but didn't find an API like onDidSaveNotebookDocument.

A similar API that's available is vscode.workspace.onDidCloseNotebookDocument, but I guess it can't work.

@venaturum
Copy link
Author

@pucelle
Copy link
Owner

pucelle commented Jun 27, 2021

OK, I guess we should just leave this issue here and wait for the API released.

@francisco-perez-sorrosal

I recently came up with the same problem and I created an issue in the VSCode github repo for that. Please upvote there!

@pucelle
Copy link
Owner

pucelle commented Aug 17, 2021

Voted

@pucelle
Copy link
Owner

pucelle commented Feb 6, 2022

Close it, never mind to reopen after everything is ready.

@pucelle pucelle closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants