fix(delete-messages): fix issue with channel encoding (#137)

fix(delete-messages): fix issue with channel encoding

Fix issue because of which channel hasn't been encoded properly with endpoint call.

Author: parfeon

.pubnub.yml

@@ -1,6 +1,11 @@
 ---
-version: "5.1.1"
+version: "5.1.2"
 changelog:
+  - date: 2022-11-23
+    version: v5.1.2
+    changes:
+      - type: bug
+        text: "Fix issue because of which channel hasn't been encoded properly with endpoint call."
   - date: 2022-10-26
     version: v5.1.1
     changes:
@@ -637,7 +642,7 @@ sdks:
                     - x86-64
           - distribution-type: package
             distribution-repository: RubyGems
-            package-name: pubnub-5.1.1.gem
+            package-name: pubnub-5.1.2.gem
             location: https://rubygems.org/gems/pubnub
             requires:
               - name: addressable
@@ -742,8 +747,8 @@ sdks:
                     - x86-64
           - distribution-type: library
             distribution-repository: GitHub release
-            package-name: pubnub-5.1.1.gem
-            location: https://github.com/pubnub/ruby/releases/download/v5.1.1/pubnub-5.1.1.gem
+            package-name: pubnub-5.1.2.gem
+            location: https://github.com/pubnub/ruby/releases/download/v5.1.2/pubnub-5.1.2.gem
             requires:
               - name: addressable
                 min-version: 2.0.0

.tool-versions

@@ -1 +1 @@
-ruby 2.7.6
+ruby 3.0.0

CHANGELOG.md

@@ -1,3 +1,9 @@
+## v5.1.2
+November 23 2022
+
+#### Fixed
+- Fix issue because of which channel hasn't been encoded properly with endpoint call.
+
 ## v5.1.1
 October 26 2022
 

Gemfile

@@ -9,7 +9,7 @@ group :test do
   gem 'rspec-retry'
   gem 'rspec-expectations'
   gem 'rubocop'
-  gem 'simplecov', '>= 0.12', require: false
+  gem 'simplecov', '>= 0.21.2', require: false
   gem 'vcr'
   gem 'webmock'
   gem 'cucumber'

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    pubnub (5.1.1)
+    pubnub (5.1.2)
       addressable (>= 2.0.0)
       concurrent-ruby (~> 1.1.5)
       concurrent-ruby-edge (~> 0.5.0)
@@ -61,7 +61,7 @@ GEM
       cucumber-messages (~> 17.0, >= 17.0.1)
     debug_inspector (0.0.3)
     diff-lcs (1.4.4)
-    docile (1.3.2)
+    docile (1.4.0)
     dry-configurable (0.11.6)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.4, >= 0.4.7)
@@ -161,10 +161,12 @@ GEM
       parser (>= 2.7.1.4)
     ruby-progressbar (1.10.1)
     safe_yaml (1.0.5)
-    simplecov (0.18.5)
+    simplecov (0.21.2)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
-    simplecov-html (0.12.2)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     spoon (0.0.6)
       ffi
     sys-uname (1.2.2)
@@ -194,7 +196,7 @@ DEPENDENCIES
   rspec-expectations
   rspec-retry
   rubocop
-  simplecov (>= 0.12)
+  simplecov (>= 0.21.2)
   vcr
   webmock
 

VERSION

@@ -1 +1 @@
-5.1.1
+5.1.2

fixtures/vcr_cassettes/examples/delete_messages_channel_non_url_friendly_name.yml

@@ -31,7 +31,7 @@ def path
         'sub-key',
         @subscribe_key,
         'channel',
-        @channel
+        Formatter.format_channel(@channel, true)
       ].join('/')
     end
 

lib/pubnub/events/delete_messages.rb

@@ -1,4 +1,4 @@
 # Toplevel Pubnub module.
 module Pubnub
-  VERSION = '5.1.1'.freeze
+  VERSION = '5.1.2'.freeze
 end

lib/pubnub/version.rb

@@ -22,6 +22,13 @@
       end
     end
 
+    it "works with channel which contains non-URL friendly characters" do
+      VCR.use_cassette("examples/delete_messages_channel_non_url_friendly_name", record: :once) do
+        envelope = pubnub.delete_messages(channel: 'demo@pubnub')
+        expect(envelope.value.status[:code]).to eq 200
+      end
+    end
+
     it "works with channel and start specified" do
       VCR.use_cassette("examples/delete_messages_channel_start", record: :once) do
         envelope = pubnub.delete_messages(channel: :demo, start: "15040071432538531")