Skip to content

Flake linter runs once before all the tests #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2023
Merged

Flake linter runs once before all the tests #159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
056d4bd
build: Flake linting runs once before tests and not after all python …
May 24, 2023
d65234e
Move linter to validators
May 25, 2023
daee58e
Merge branch 'master' into build/flake-before-tests
May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,31 @@ env:
PN_KEY_PAM_SECRET: ${{ secrets.PN_KEY_PAM_SECRET }}

jobs:
lint:
name: Lint project
runs-on: ubuntu-latest
steps:
- name: Checkout project
uses: actions/checkout@v3
- name: Setup Python 3.11
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Install Python dependencies and run acceptance tests
run: |
sudo pip3 install -r requirements-dev.txt
flake8 --exclude=scripts/,src/,.cache,.git,.idea,.tox,._trial_temp/,venv/ --ignore F811,E402
- name: Cancel workflow runs for commit on error
if: failure()
uses: ./.github/.release/actions/actions/utils/fast-jobs-failure
tests:
name: Integration and Unit tests
runs-on: ubuntu-latest
needs: [lint]
strategy:
fail-fast: true
matrix:
python: [3.7.13, 3.8.13, 3.9.13, 3.10-dev]
python: [3.7.13, 3.8.13, 3.9.13, 3.10.11, 3.11.3]
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand All @@ -51,6 +69,7 @@ jobs:
acceptance-tests:
name: Acceptance tests
runs-on: ubuntu-latest
needs: [lint]
steps:
- name: Checkout project
uses: actions/checkout@v3
Expand Down
3 changes: 2 additions & 1 deletion scripts/run-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ def run(command):


run(tcmn)
run(fcmn)
# moved to separate action
# run(fcmn)