Skip to content

Commit 484df21

Browse files
author
Sebastian Molenda
authored
Flake linter runs once before all the tests (#159)
* build: Flake linting runs once before tests and not after all python versions * Move linter to validators
1 parent 39d1897 commit 484df21

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
strategy:
2525
fail-fast: true
2626
matrix:
27-
python: [3.7.13, 3.8.13, 3.9.13, 3.10-dev]
27+
python: [3.7.13, 3.8.13, 3.9.13, 3.10.11, 3.11.3]
2828
steps:
2929
- name: Checkout repository
3030
uses: actions/checkout@v3

.github/workflows/run-validations.yml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,23 @@ name: Validations
33
on: [push]
44

55
jobs:
6+
lint:
7+
name: Lint project
8+
runs-on: ubuntu-latest
9+
steps:
10+
- name: Checkout project
11+
uses: actions/checkout@v3
12+
- name: Setup Python 3.11
13+
uses: actions/setup-python@v4
14+
with:
15+
python-version: '3.11'
16+
- name: Install Python dependencies and run acceptance tests
17+
run: |
18+
sudo pip3 install -r requirements-dev.txt
19+
flake8 --exclude=scripts/,src/,.cache,.git,.idea,.tox,._trial_temp/,venv/ --ignore F811,E402
20+
- name: Cancel workflow runs for commit on error
21+
if: failure()
22+
uses: ./.github/.release/actions/actions/utils/fast-jobs-failure
623
pubnub-yml:
724
name: "Validate .pubnub.yml"
825
runs-on: ubuntu-latest
@@ -26,7 +43,7 @@ jobs:
2643
all-validations:
2744
name: Validations
2845
runs-on: ubuntu-latest
29-
needs: [pubnub-yml]
46+
needs: [pubnub-yml, lint]
3047
steps:
3148
- name: Validations summary
3249
run: echo -e "\033[38;2;95;215;0m\033[1mAll validations passed"

scripts/run-tests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@ def run(command):
2020

2121

2222
run(tcmn)
23-
run(fcmn)
23+
# moved to separate action
24+
# run(fcmn)

0 commit comments

Comments
 (0)