Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was :fallback accidentally left out? #377

Open
goldstar611 opened this issue Nov 8, 2022 · 1 comment
Open

Was :fallback accidentally left out? #377

goldstar611 opened this issue Nov 8, 2022 · 1 comment
Assignees

Comments

@goldstar611
Copy link

Pull request #148 introduced :fallback but I can't find any branch or gem release with that parameter now. It used to be part of the "2.0" / "unstable" branch but now that 2.0 is released it's definitely gone.

The way the if..else statement in renderable.rb is such that if :display is defined it is always used.

If I sent a PR to re-introduce :fallback would that be acceptable or was :fallback removed intentionally?

Thanks!

@ur5us
Copy link
Collaborator

ur5us commented Jul 7, 2023

As far as I can tell, this feature never made it into a release. However, the code is still there in the master branch.

$ git br --contains a2e9aa5a7f131ae69c805acb9c445d3685de141b
  master

@ur5us ur5us reopened this Jul 7, 2023
@ur5us ur5us self-assigned this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants