Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the redant dependency to v0.4.0, removes the legacy cmux package, and refactors configuration flags by replacing the Category field with an Inherit property. It also adjusts the return signature of an environment validation helper in tests and optimizes string buffering in the migration component. Reviewers identified a likely bug in the migration logic where a database driver name is accessed incorrectly. Additionally, feedback was provided regarding missing Inherit: true properties on several flags (gRPC port and feature flags) to ensure consistency with the new configuration model.
| Description: flag.Usage, | ||
| Value: flag.Value, | ||
| Default: flag.Value.String(), | ||
| Category: category, |
There was a problem hiding this comment.
The Category field was removed, but Inherit: true was not added. For consistency with other flags updated in this PR (such as those in running/runtime.go), feature flags should likely be inherited so they are available to subcommands.
| Category: category, | |
| Inherit: true, |
| Description: "service grpc port", | ||
| Value: GrpcPort, | ||
| Default: GrpcPort.String(), | ||
| Category: "system", |
There was a problem hiding this comment.
The GrpcPortFlag is missing the Inherit: true property, which is inconsistent with the updates made to DebugFlag, EnvFlag, and HttpPortFlag. Since the Category field was removed, this flag should likely be marked for inheritance as well to maintain the intended behavior for system flags.
| Category: "system", | |
| Inherit: true, |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 participant
No description provided.