Skip to content

[RV64_DYNAREC] Fixed SBB16/SBB32 scratch register clobbering in flag calculation #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptitSeb merged 1 commit into from
May 24, 2026
+2 −2
Merged

[RV64_DYNAREC] Fixed SBB16/SBB32 scratch register clobbering in flag calculation #3889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dynarec/rv64/dynarec_rv64_emit_math.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,7 +1040,7 @@ void emit_sbb16(dynarec_rv64_t* dyn, int ninst, int s1, int s2, int s3, int s4,
CLEAR_FLAGS();
SLLIW(s1, s1, 16);
IFX (X_SF) {
SET_FLAGS_LTZ(s1, F_SF, s4, s5);
SET_FLAGS_LTZ(s1, F_SF, s3, s4);
}
SRLIW(s1, s1, 16);

Expand Down Expand Up @@ -1080,7 +1080,7 @@ void emit_sbb32(dynarec_rv64_t* dyn, int ninst, rex_t rex, int s1, int s2, int s

CLEAR_FLAGS();
IFX (X_SF) {
SET_FLAGS_LTZ(s1, F_SF, s4, s5);
SET_FLAGS_LTZ(s1, F_SF, s3, s4);
}
if (!rex.w && (IS_GPR(s1) || dyn->insts[ninst].nat_flags_fusion)) {
ZEROUP(s1);
Expand Down
Loading