[RV64_DYNAREC] Fixed ANDNPS/ANDNPD/PANDN register reuse conflict in vector path#3883
Merged
Merged
Conversation
ksco
approved these changes
May 22, 2026
ptitSeb
reviewed
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix register reuse conflict in SSE ANDNPS/ANDNPD/PANDN for RV64 vector dynarec.
When Gx and Ex refer to the same register, VXOR_VI clobbers the source value while computing the NOT, causing VAND_VV to operate on incorrect data.
This patch detects the aliasing case and copies the source to a scratch register before applying NOT.
Affected instructions:
Validation: