Test fixes / tweaks #694
Open
Test fixes / tweaks #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fate-JH
reviewed
Feb 27, 2021
| class PlayerControlInteractWithWaterTest extends ActorTest { | ||
| val player1 = | ||
| Player(Avatar(0, "TestCharacter1", PlanetSideEmpire.TR, CharacterGender.Male, 0, CharacterVoice.Mute)) //guid=1 | ||
| player1.Definition.UnderwaterLifespan(suffocation = 3000, recovery = 3000) // Override the default 60s down / 10s recovery so the tests don't take forever to run |
Contributor
There was a problem hiding this comment.
player1.Definition.UnderwaterLifespan(...)
As with my far far ealiertests involving a singleton classes is evidenced, changing a single source class for one test changes it for every test. All tests involving a drowning player will endure this 3000ms / 3000ms time limit. Given the reliability of actor tests, depending on the order they are implemented, it's possible that a test whose constituent actors may receive less attention than hoped may be affected by these updates times. In other words, it'll drown faster too.
GlobalDefinitions can be like a singleton to all tests in that respect.
Contributor
|
This one still in flux? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some of the flaky tests and speed up some of the water related ones.
There's still a failure with
VehicleControlInteractWithWaterTesthowever, and I have no idea why. It runs perfectly fine when ran on it's own, but in a batch of all tests will fail even with greatly exaggerated timeouts for the expected message. Even running it in a smaller batch seems to work@Fate-JH If you have any ideas on the above let me know.