CSR Dismount

[Fate-JH]

CSR players were failing to bail from moving vehicles and that resulted in breaking the dismount routines, causing lag, spamming event chat, and even crashing the client. The policy was always that CSR players have priority to dismount/eject/bail from vehicles and that's why this fix was composed.

Exhaustive conditions for the bail system failing and for avoiding situations where the player should not be allowed to bail from the vehicle based on how long since it had been spawned, even if they were working correctly, made narrowing cases an minor issue. I condensed five cases into two. Someone more familiar with the bail failure code and the code that stopped people from bailing too early should make certain the logic for that holds up to your expectations.

Literal instructions:

• be CSR-level player
• spawn vehicle
• get in vehicle (automatic)
• drive vehicle forward (once control has been restored)
• dismount (bail or otherwise)

Expectation

• player should get out of vehicle

[Dethdeath]

Bailing for GMs works without the previous spam (and related lag).
I guess you know about everything that can happen if you bail before vehicle control has been restored, but GMs should just be aware of that then.

[Fate-JH]

Stopping a player from exitting a vehicle too early should be what the DriveState.AutoPilot flag is for. It should last from spawn pad trench until the server has restored control to the driver (or unoccupied vehicle). If it's not doing that, I need to re-examine the vehicle spawn protocol.

[Dethdeath]

Yeah it's not doing that for GMs.