Use an invalid URI that will not cause httpbin to throw 500#6700
Merged
sigmavirus24 merged 1 commit intopsf:mainfrom May 12, 2024
Merged
Conversation
sigmavirus24
approved these changes
May 12, 2024
This was referenced Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context in urllib3/urllib3#3392
Urllib3's CI started failing due to the requests
test_redirecting_to_bad_urlfailing. The test started failing, beacuse httpbin started returning 500 on initial request, instead of a 302. I think this would break requests CI as well if it were run now.Modified the redirect to URI to something that will not cause httpbin to throw a 500, but is still an invalid URI.