Remove Python 2 mention on chardet behavior
#6204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
approved these changes
Jul 27, 2022
nateprewitt
requested changes
Jul 27, 2022
Member
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Asked for a small additional change, but otherwise looks good!
docs/user/advanced.rst
Outdated
| cannot depend on mandatory LGPL-licensed dependencies. | ||
|
|
||
| When you install ``request`` without specifying ``[use_chardet_on_py3]]`` extra, | ||
| When you install ``requests`` without specifying ``[use_chardet_on_py3]]`` extra, |
Member
There was a problem hiding this comment.
Not directly related to your change but while we’re here can we remove the erroneous ] at the end of the extra?
Contributor
Author
There was a problem hiding this comment.
Absolutely! Sorry I missed that.
`requests` no longer supports Python 2. A recent commit, 8bce583 removed the `chardet` dependency for Python 2: ```diff -'chardet>=3.0.2,<5; python_version < "3"', ``` We should edit the docs to remove mention of behavior on Py2.
DavidCain
force-pushed
the
dcain-chardet-py2
branch
from
6275853 to
ff8f445
Compare
Contributor
Author
|
Thank you both for the extremely speedy review! It does look like I'll need a maintainer to kick off CI though. |
nateprewitt
approved these changes
Jul 27, 2022
Member
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Looks good, thanks @DavidCain!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestsno longer supports Python 2. A recent commit, 8bce583removed the
chardetdependency for Python 2:-'chardet>=3.0.2,<5; python_version < "3"',We should edit the docs to remove mention of behavior on Py2.