A few more small CI tweaks #4978
Open
+224
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Most dev/ci depedencies were pinned to a specific version, except for bigger projects with lots of updates. - For runtime dependencies, I took care not to remove any versions from the range of supported versions. Wherever I could I changed `>=` to `~=` to avoid bumping major versions.
- Update cibuildhweel in GHA and pyproject together - Use default update schedule - Add maintenance label to GHA PRs Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
…pdate-stable job to it Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
…abels Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
Signed-off-by: cobalt <61329810+cobaltt7@users.noreply.github.com>
| dependencies = [ | ||
| "click>=8.0.0", | ||
| "mypy_extensions>=0.4.3", | ||
| "click~=8.0", |
Collaborator
There was a problem hiding this comment.
I'm strongly against these changes. In practice, major versions aren't an especially good indicator of when something will break. And when dealing with a large Python environment, unnecessary upper version constraints are often a pain to deal with because they restrict what packages can live in the same environment. I would only use upper bounds if we know that Black is incompatible with some version of a package.
Collaborator
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small followup to #4928 with a few more things I noticed since then
Notable changes:
>=to~=to avoid bumping major versionsI didn't change any ranges that already included multiple major versions
No currently-released versions that were previously allowed are now disallowed
skip newstoci: skip newsfor consistency with other CI labels(changelog action will fail on this PR until it's updated on the GH side)
Checklist - did you ...
--previewstyle, following the stability policy?CHANGES.mdif necessary?