Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant parentheses in for loop unpacking #2338

Closed
felix-hilden opened this issue Jun 16, 2021 · 0 comments · Fixed by #2945
Closed

Redundant parentheses in for loop unpacking #2338

felix-hilden opened this issue Jun 16, 2021 · 0 comments · Fixed by #2945
Labels
F: parentheses Too many parentheses, not enough parentheses, and so on. T: style What do we want Blackened code to look like?

Comments

@felix-hilden
Copy link
Collaborator

Related to tuple unpacking opinions in #445.

Describe the style change
Unnecessary parentheses in for loop variable unpacking should be removed.

Examples in the current Black style

for (a, b) in c:
    pass

Desired style

for a, b in c:
    pass
@felix-hilden felix-hilden added T: style What do we want Blackened code to look like? F: parentheses Too many parentheses, not enough parentheses, and so on. labels Jun 16, 2021
@JelleZijlstra JelleZijlstra changed the title Remove unnecessary parentheses in for unpacking Redundant parentheses in for loop unpacking Jan 29, 2022
@JelleZijlstra JelleZijlstra mentioned this issue Feb 28, 2022
Closed
@jpy-git jpy-git mentioned this issue Mar 22, 2022
Merged
3 tasks
@felix-hilden felix-hilden mentioned this issue May 20, 2022
Open
@heerener heerener mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F: parentheses Too many parentheses, not enough parentheses, and so on. T: style What do we want Blackened code to look like?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary parentheses from tuple unpacking in for loops jpy-git/black
1 participant
@felix-hilden