hasBackButton property #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aitorct, this is awesome! One little question, can we modify the resource of the icon from our projects? :) |
I did use the default Android back button icon (arrow left). Just like the cross, it's not supposed to be changed to a custom one, isn't it? I just kept the same behavior as the cross. |
phuongwd
pushed a commit
to phuongwd/react-native-inappbrowser
that referenced
this pull request
Jul 31, 2020
hasBackButton property
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets a back arrow instead of the default X icon to close the custom tab, if
hasBackButtonproperty istrue.I had to use PNGs because Custom Tab does not support SVG/Vector files as custom close buttons. I compressed the image files using ImageOptim.
This solves #85.