-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close inappbrowser on deeplink #312
Comments
Hi, Uppon more investigation, I found out that the deeplinks work correctly (e.g. they open the correct screen using react navigation) however when clicking the deeplink, the inappbrowser modal does not close... |
@BenjaminSAILcloud take a look at a console of the page that should redirect user back to the app, probably you will see something like this: "Navigation is blocked: ...". I'm facing this issue as well. Here's what I've found so far. https://bugs.chromium.org/p/chromium/issues/detail?id=738724 The issue breaks auth flows with some 3rd party in my case. Users are not redirected back to the app after authentication. |
Hello folks, please share a reproducible demo project to be able to debug your issue 👍 |
This comment has been minimized.
This comment has been minimized.
Appreciate the attention Issue reproduced here: https://github.com/mongkuen/RNInAppBrowser-deeplink-demo Video of issue |
I second this. We have payment integration via InAppBrowser and have been using @jdnichollsc Is there a reason why the redirection logic has only been implemented for Oh, and on Android everything works fine. The Custom Tabs knows how to redirect out of the box. |
This is probably a Not an iOS/Objective C dev, and this solution is in swift, but I imagine this approach here might be close to the desired behavior? Then maybe a documentation section on how to modify Thank you whoever is taking a look at this, it's very much appreciated :) |
Yeah, something's up here. The |
We're using the same strategy of WebBrowser (Expo), please check here for more details |
Hey @TheWirv, I wanted to let you know that I got the comment you referenced to work by adding this to the func application(_ app: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {
return RCTLinkingManager.application(app, open: url, options: options)
} Hope it helps! |
FYI, if you just want to close the in-app browser after handling a deep link, you just need to do: InAppBrowser.close() In your |
This does not seem to work for me as the callback is executed after the browser is closed. (OnAndroid) When pressing the menu --> "Open in Chrome" then the redirect is handled properly and redirects to the APP |
Which platform(s) does your issue occur on?
Please, provide the following version numbers that your issue occurs with:
Hi,
I am using the inappbrowser to access a social website and I am NOT using it for authentication. In this website, there are buttons that links back to the app using deeplinks. I know they are working because when I access the website in browsers (e.g. Safari or Chrome) on the device, the deeplinks opens the app on the correct page. However when using the inappbrowser nothing happens.
How can I make the inappbrowser to handle correctly deeplinks without using the openAuth() method ?
Thanks
The text was updated successfully, but these errors were encountered: