Add experimental "no-panic" feature. #319
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabled, any "this should never happen" errors in dispatcher and/or hostcalls will be logged, but the processing will continue as if nothing happened, instead of panicking and trapping WasmVM. Note that any execution past the "should have panicked" point is undefined, since the state of contexts can get out-of-sync with the host when errors and/or events are being ignored. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
PiotrSikora
commented
Jun 6, 2025
| @@ -14,6 +14,10 @@ build = "build.rs" | |||
| hashbrown = "0.15" | |||
| log = "0.4" | |||
|
|
|||
| [features] | |||
| default = [] | |||
| no-panic = [] | |||
There was a problem hiding this comment.
Note: This will depend on the header-value (#287) once that PR is merged in order to eliminate the UTF-8 panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled, any "this should never happen" errors in dispatcher
and/or hostcalls will be logged, but the processing will continue
as if nothing happened, instead of panicking and trapping WasmVM.
Note that any execution past the "should have panicked" point
is mostly undefined, since the state of any objects might get
out-of-sync with the host when errors and/or events are being
ignored.