Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid downloading already available NPM modules. #152

Merged
merged 2 commits into from
May 1, 2023
Merged

Avoid downloading already available NPM modules. #152

merged 2 commits into from
May 1, 2023

Conversation

martijneken
Copy link
Contributor

@martijneken martijneken commented Apr 27, 2023 •
edited by PiotrSikora
Loading

Fixes #149.

@martijneken
Patch from Envoy: exclude emsdk targets for Bazel/gcc. Fixes proxy-wa…
afe2a1b 
…sm#149.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken mentioned this pull request Apr 27, 2023
Closed
PiotrSikora
PiotrSikora approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@PiotrSikora PiotrSikora changed the title Patch from Envoy: exclude emsdk targets for Bazel/gcc. Fixes #149. Avoid downloading already available NPM modules. Apr 28, 2023
@mpwarres mpwarres merged commit 921039a into proxy-wasm:master May 1, 2023
@martijneken martijneken deleted the emsdk-3.1.7-patch-only branch May 2, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Bazel build with emsdk 3.1.7
3 participants
@martijneken @PiotrSikora @mpwarres