Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing Wasm-side log level #153

Open
martijneken opened this issue May 8, 2023 · 0 comments
Open

Consider implementing Wasm-side log level #153

martijneken opened this issue May 8, 2023 · 0 comments

Comments

@martijneken
Copy link
Contributor

martijneken commented May 8, 2023

In the Rust SDK (and Rust in general) there's a built-in configurable log level:
https://docs.rs/log/latest/log/fn.set_max_level.html

The Rust logger does Wasm-side log filtering based on level:
https://github.com/proxy-wasm/proxy-wasm-rust-sdk/blob/master/src/logger.rs#L51-L53

This would be nice to have in C++ also. Currently every C++log message is transmitted to the host:
https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/blob/master/proxy_wasm_api.h#L61-L92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant