Skip to content

v8: fix build on Windows. #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 48 commits into from
Closed

v8: fix build on Windows. #211

Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
6814b83
build: test V8 on Windows.
PiotrSikora Jan 5, 2022
03dd53f
review: take #2.
PiotrSikora Jan 5, 2022
ff5f393
review: /Zm1000 and :generated_inspector_files.
PiotrSikora Jan 5, 2022
7061fad
review: update V8 to v9.9.62.
PiotrSikora Jan 6, 2022
2870761
Merge remote-tracking branch 'origin/master' into PiotrSikora/build_win
PiotrSikora Jan 6, 2022
87dfbb2
review: move "cmd" to bash script.
PiotrSikora Jan 6, 2022
fa15d1f
review: fix typo.
PiotrSikora Jan 6, 2022
ed687dc
review: add "cmd_ps" for Windows.
PiotrSikora Jan 6, 2022
d3945ba
review: fixup.
PiotrSikora Jan 6, 2022
c11699e
review: fixup.
PiotrSikora Jan 6, 2022
670b0d2
review: debug.
PiotrSikora Jan 6, 2022
6b00bbb
review: trace.
PiotrSikora Jan 6, 2022
da6e8e1
review: debug.
PiotrSikora Jan 6, 2022
920c0ca
review: enable runfiles.
PiotrSikora Jan 6, 2022
363ffca
review: quote command.
PiotrSikora Jan 6, 2022
ec4432c
review: more quotes...
PiotrSikora Jan 6, 2022
8513c27
review: Start-Process.
PiotrSikora Jan 6, 2022
aea5378
review: cmd.exe.
PiotrSikora Jan 6, 2022
7084521
review: fix slashes.
PiotrSikora Jan 6, 2022
e14f747
review: Get-ItemProperty.
PiotrSikora Jan 6, 2022
1ef0c44
review: update patchset.
PiotrSikora Jan 6, 2022
09051db
review: fixup.
PiotrSikora Jan 6, 2022
7ae0505
review: update V8 to v9.9.67 and regenerate patches.
PiotrSikora Jan 7, 2022
c740d2f
Merge remote-tracking branch 'origin/master' into PiotrSikora/build_win
PiotrSikora Jan 11, 2022
05c3677
review: revert --enable_runfiles.
PiotrSikora Jan 11, 2022
e2926f1
review: add /DEBUG:FULL on Windows.
PiotrSikora Jan 11, 2022
85dc6b2
review: add trailing comma.
PiotrSikora Jan 11, 2022
6a0e978
review: generate torque files in a separate step.
PiotrSikora Jan 11, 2022
28deaac
review: fix conditional steps.
PiotrSikora Jan 11, 2022
5bbdbb6
review: run only Windows build during testing.
PiotrSikora Jan 11, 2022
0ed058e
review: test different /DEBUG values.
PiotrSikora Jan 11, 2022
28a79ff
review: test /Zi.
PiotrSikora Jan 11, 2022
f6c2dbe
review: try --copt.
PiotrSikora Jan 11, 2022
8fbf0dc
review: try Wasmtime.
PiotrSikora Jan 11, 2022
3768cbd
Revert "review: try Wasmtime."
PiotrSikora Jan 13, 2022
5f362de
Merge remote-tracking branch 'origin/master' into PiotrSikora/build_win
PiotrSikora Jan 13, 2022
ea3903f
review: multiline fix?
PiotrSikora Jan 12, 2022
339c787
review: add some Windows hacks.
PiotrSikora Jan 13, 2022
a320f10
review: fix multiline.
PiotrSikora Jan 13, 2022
be11885
Merge remote-tracking branch 'origin/master' into PiotrSikora/build_win
PiotrSikora Jan 28, 2022
8512d9b
review: add /bigobj.
PiotrSikora Jan 28, 2022
f2d0760
review: drop cache.
PiotrSikora Jan 28, 2022
8f05b31
review: fix typo.
PiotrSikora Jan 28, 2022
b5271b6
Merge remote-tracking branch 'origin/master' into PiotrSikora/build_win
PiotrSikora Feb 18, 2022
5b41ac5
review: use bash.
PiotrSikora Feb 18, 2022
7ee8e84
review: try /Os.
PiotrSikora Feb 18, 2022
17cdf3b
review: try /O1, drop /DEBUG:FULL.
PiotrSikora Feb 18, 2022
a56b8ce
Merge remote-tracking branch 'origin/master' into PiotrSikora/build_win
PiotrSikora Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review: Get-ItemProperty. 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
  • Loading branch information
@PiotrSikora
PiotrSikora committed Jan 6, 2022
commit e14f747dcc00361458e2f172fbbd2068ebf1d078
2 changes: 1 addition & 1 deletion bazel/external/v8.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ index 0000000000..6273e8acef
+echo $ModifiedConfig
+Set-Content modified_config.json $ModifiedConfig
+
+& "$Generator" --jinja_dir . --inspector_protocol_dir third_party/inspector_protocol --config modified_config.json --output_base $OutputDir
+Get-ItemProperty "$Generator"
diff --git a/bazel/generate-inspector-files.sh b/bazel/generate-inspector-files.sh
index 9547041c33..8950c5dcff 100755
--- a/bazel/generate-inspector-files.sh
Expand Down