Skip to content

Commit 7bcf22e

Browse files
committed
Reflect the comments
Signed-off-by: Ingwon Song <igsong@google.com>
1 parent edbe96f commit 7bcf22e

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

test/test_data/configure_check.cc

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,7 @@ class TestRootContext1 : public RootContext {
2323
explicit TestRootContext1(uint32_t id, std::string_view root_id) : RootContext(id, root_id) {}
2424
bool onConfigure(size_t s) override {
2525
LOG_TRACE("onConfigure: root_id_1");
26-
if (s == 0) {
27-
return false;
28-
}
29-
return true;
26+
return s != 0;
3027
}
3128
};
3229

@@ -40,10 +37,7 @@ class TestRootContext2 : public RootContext {
4037
explicit TestRootContext2(uint32_t id, std::string_view root_id) : RootContext(id, root_id) {}
4138
bool onConfigure(size_t s) override {
4239
LOG_TRACE("onConfigure: root_id_2");
43-
if (s == 0) {
44-
return false;
45-
}
46-
return true;
40+
return s != 0;
4741
}
4842
};
4943

test/wasm_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ TEST_P(TestVm, AlwaysApplyCanary) {
205205
// configure_check.wasm should raise the error at `onConfigure` in canary when the
206206
// `plugin_config` is empty string.
207207
EXPECT_EQ(wasm_handle_comp, nullptr);
208-
return;
208+
continue;
209209
}
210210

211211
ASSERT_TRUE(wasm_handle_comp && wasm_handle_comp->wasm());

0 commit comments

Comments
 (0)