Review use of user supplied information in logging entries

[iramiller]

Summary

Recently there have been some concerns over what information a user can submit that will end up directly in a log message. This issue is to review all the fmt.Sprintf usage within errors in the provenanced project and sanitize resulting output where appropriate.

Problem Definition

Users having control over output that is logged in error messages can have unintended consequences and can potentially open up systems to attack. Encoding or otherwise preventing direct control of output based on user inputs is a standard security best practice.

Proposal

Search through the project for uses of fmt.Sprintf. Audit all occurrences for use of user supplied input and remove these instances.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[dwedul-figure]

Probably need to include the actual logger calls too: .Debug(, .Info(, .Error(, and .With(.

All output in unit tests should use either t.Log(...) or s.T().Log(...) instead of fmt.Printf or related.

[iramiller]

@llama-del-rey you might want 👀 on this one