Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add injectable locked coins function into the bank module. #1619

Closed
4 tasks
SpicyLemon opened this issue Jul 5, 2023 · 0 comments
Closed
4 tasks

Add injectable locked coins function into the bank module. #1619

SpicyLemon opened this issue Jul 5, 2023 · 0 comments
Assignees
Labels
bank Bank Module cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK enhancement New feature or request
Milestone

Comments

@SpicyLemon
Copy link
Contributor

Summary

Add a way to inject a "locked coins" function into the bank module as a way for other modules to indicate certain funds are locked.

Problem Definition

When we mark funds as being in escrow, it'd be nice if the bank module didn't still indicate that they are spendable.

Proposal

Similar to the SendRestrictionFn stuff, add a way to inject a LockedCoinsFn that returns an sdk.Coins indicating funds that are locked. Update the LockedCoins keeper function to call the injected function and add them to whatever it's currently returning.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@SpicyLemon SpicyLemon added enhancement New feature or request bank Bank Module cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK labels Jul 5, 2023
@SpicyLemon SpicyLemon added this to the v1.17.0 milestone Jul 5, 2023
@SpicyLemon SpicyLemon self-assigned this Jul 5, 2023
@SpicyLemon SpicyLemon moved this from Todo to In Progress in Provenance Core Protocol Team Jul 5, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Provenance Core Protocol Team Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bank Bank Module cosmos-sdk Issues/PRs related to our fork of the Cosmos-SDK enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant