Skip to content

Commit 6a40146

Browse files
authored
BE: Throw obvious exception in case no oauth2 providers have been defined (#4002)
1 parent 4515eca commit 6a40146

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/auth/OAuthSecurityConfig.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,9 @@ public InMemoryReactiveClientRegistrationRepository clientRegistrationRepository
9999
final OAuth2ClientProperties props = OAuthPropertiesConverter.convertProperties(properties);
100100
final List<ClientRegistration> registrations =
101101
new ArrayList<>(new OAuth2ClientPropertiesMapper(props).asClientRegistrations().values());
102+
if (registrations.isEmpty()) {
103+
throw new IllegalArgumentException("OAuth2 authentication is enabled but no providers specified.");
104+
}
102105
return new InMemoryReactiveClientRegistrationRepository(registrations);
103106
}
104107

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
package com.provectus.kafka.ui.config.auth.condition;
22

33
import com.provectus.kafka.ui.service.rbac.AbstractProviderCondition;
4+
import org.jetbrains.annotations.NotNull;
45
import org.springframework.context.annotation.Condition;
56
import org.springframework.context.annotation.ConditionContext;
67
import org.springframework.core.type.AnnotatedTypeMetadata;
78

89
public class CognitoCondition extends AbstractProviderCondition implements Condition {
910
@Override
10-
public boolean matches(final ConditionContext context, final AnnotatedTypeMetadata metadata) {
11+
public boolean matches(final ConditionContext context, final @NotNull AnnotatedTypeMetadata metadata) {
1112
return getRegisteredProvidersTypes(context.getEnvironment()).stream().anyMatch(a -> a.equalsIgnoreCase("cognito"));
1213
}
13-
}
14+
}

0 commit comments

Comments
 (0)