This repository was archived by the owner on Jan 2, 2024. It is now read-only.
Adding is_disabled option #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The underlying Analytics package will simply return a NullResponse when prompted to send events to GA if the argument $isDisabled=true in its constructor. Ideally I would have included a test here, but there didn't appear to be a simple way to check that -- and it seemed like a fairly benign adjustment to me. |
|
@pascalbaljet Can we help merge this in? |
|
Checking in on this... |
|
👋 Was looking for a way to disable the package during tests. Currently it sends a ton of requests to Google 😬 |
|
I've changed it to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.