Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1b0b1c9ba005e85292cf597de6bcb64c69eeb23a
Choose a base ref
...
head repository: protocolbuffers/protobuf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8c9b653519d02713beb16488ac9d9e9dfdeb295a
Choose a head ref
  • 9 commits
  • 31 files changed
  • 5 contributors

Commits on Dec 11, 2024

  1. Internal change 

    PiperOrigin-RevId: 705107336
    @honglooker @copybara-github
    honglooker authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    e170c43 View commit details
    Browse the repository at this point in the history

  2. hpb: collapse Serialize with PtrOrRaw<T> 

    PiperOrigin-RevId: 705119290
    @honglooker @copybara-github
    honglooker authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    5471f18 View commit details
    Browse the repository at this point in the history

  3. Source the regeneration script instead of spawning a new process. 

    This keeps the environment variables hooked up

PiperOrigin-RevId: 705122684
    @mkruskal-google @copybara-github
    mkruskal-google authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    494e28b View commit details
    Browse the repository at this point in the history

  4. Export environment variables so bazelisk picks them up 

    PiperOrigin-RevId: 705148623
    @mkruskal-google @copybara-github
    mkruskal-google authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    20ea8af View commit details
    Browse the repository at this point in the history

  5. Auto-generate files after cl/705148623

    @protobuf-team-bot
    protobuf-team-bot committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    2598c6d View commit details
    Browse the repository at this point in the history

  6. Delete old conformance test hack 

    This is no longer relevant, and all 3 python implementations are conformant in JSON and binary formats

PiperOrigin-RevId: 705214440
    @mkruskal-google @copybara-github
    mkruskal-google authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    b9cb184 View commit details
    Browse the repository at this point in the history

  7. Make Java consistently reject unmatched end-group tag. 

    This brings it into conformance with our spec and other languages.  Some parse paths already did this check, and all of them prohibit *nested* unmatched end-group tags.

PiperOrigin-RevId: 705225060
    @mkruskal-google @copybara-github
    mkruskal-google authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    a4d4bfe View commit details
    Browse the repository at this point in the history

  8. IWYU & clang-tidy fixes in reflection_internal.h 

    PiperOrigin-RevId: 705243129
    @protobuf-github-bot @copybara-github
    protobuf-github-bot authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    33a6db1 View commit details
    Browse the repository at this point in the history

  9. Rust: set links = "upb" instead of links = "libupb" 

    According to the docs [here](https://doc.rust-lang.org/cargo/reference/build-scripts.html#the-links-manifest-key),
the `lib` prefix is implied and shouldn't be spelled out here.

PiperOrigin-RevId: 705262087
    @acozzette @copybara-github
    acozzette authored and copybara-github committed Dec 11, 2024
    Configuration menu
    Copy the full SHA
    8c9b653 View commit details
    Browse the repository at this point in the history
Loading