Skip to content

Commit 489aba5

Browse files
Merge pull request #15984 from mkruskal-google/staleness-fix-25
Actually fail if staleness fail
2 parents 982aac0 + 367c7be commit 489aba5

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/workflows/staleness_check.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,7 @@ jobs:
5252
run: |
5353
set -ex
5454
if [[ -z $COMMIT_TRIGGERED_RUN || -z $MAIN_RUN ]]; then
55-
bazel query 'attr(tags, "staleness_test", //...)' | xargs bazel test $BAZEL_FLAGS || \
56-
echo "Please run ./regenerate_stale_files.sh to regenerate stale files"
55+
bazel query 'attr(tags, "staleness_test", //...)' | xargs bazel test $BAZEL_FLAGS
5756
else
5857
bazel query 'attr(tags, "staleness_test", //...)'
5958
fi

php/ext/google/protobuf/php-upb.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10178,7 +10178,7 @@ const upb_FileDef* upb_DefPool_FindFileByNameWithSize(const upb_DefPool* s,
1017810178
const upb_FieldDef* upb_DefPool_FindExtensionByMiniTable(
1017910179
const upb_DefPool* s, const upb_MiniTableExtension* ext);
1018010180

10181-
const upb_FieldDef* upb_DefPool_FindExtensionByName(const upb_DefPool* s,
10181+
UPB_API const upb_FieldDef* upb_DefPool_FindExtensionByName(const upb_DefPool* s,
1018210182
const char* sym);
1018310183

1018410184
const upb_FieldDef* upb_DefPool_FindExtensionByNameWithSize(
@@ -10201,7 +10201,7 @@ UPB_API const upb_FileDef* upb_DefPool_AddFile(
1020110201
upb_DefPool* s, const UPB_DESC(FileDescriptorProto) * file_proto,
1020210202
upb_Status* status);
1020310203

10204-
const upb_ExtensionRegistry* upb_DefPool_ExtensionRegistry(
10204+
UPB_API const upb_ExtensionRegistry* upb_DefPool_ExtensionRegistry(
1020510205
const upb_DefPool* s);
1020610206

1020710207
const upb_FieldDef** upb_DefPool_GetAllExtensions(const upb_DefPool* s,

ruby/ext/google/protobuf_c/ruby-upb.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10682,7 +10682,7 @@ const upb_FileDef* upb_DefPool_FindFileByNameWithSize(const upb_DefPool* s,
1068210682
const upb_FieldDef* upb_DefPool_FindExtensionByMiniTable(
1068310683
const upb_DefPool* s, const upb_MiniTableExtension* ext);
1068410684

10685-
const upb_FieldDef* upb_DefPool_FindExtensionByName(const upb_DefPool* s,
10685+
UPB_API const upb_FieldDef* upb_DefPool_FindExtensionByName(const upb_DefPool* s,
1068610686
const char* sym);
1068710687

1068810688
const upb_FieldDef* upb_DefPool_FindExtensionByNameWithSize(
@@ -10705,7 +10705,7 @@ UPB_API const upb_FileDef* upb_DefPool_AddFile(
1070510705
upb_DefPool* s, const UPB_DESC(FileDescriptorProto) * file_proto,
1070610706
upb_Status* status);
1070710707

10708-
const upb_ExtensionRegistry* upb_DefPool_ExtensionRegistry(
10708+
UPB_API const upb_ExtensionRegistry* upb_DefPool_ExtensionRegistry(
1070910709
const upb_DefPool* s);
1071010710

1071110711
const upb_FieldDef** upb_DefPool_GetAllExtensions(const upb_DefPool* s,

0 commit comments

Comments
 (0)