Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

complain if a version is appended to version.json #302

Closed
mvdan opened this issue Mar 16, 2022 · 2 comments
Closed

complain if a version is appended to version.json #302

mvdan opened this issue Mar 16, 2022 · 2 comments

Comments

@mvdan
Copy link
Contributor

mvdan commented Mar 16, 2022

I reviewed and approved ipld/go-codec-dagpb#37 to bump the semver bugfix version, and it worked when merged - the tag appeared etc. I just didn't notice that the git diff was adding one object key-value, rather than replacing the existing one.

I get that, semantically, it's the same - when decoding, the second key-value wins. Still, to avoid confusion, I think the versioning workflow should reject any version.json that isn't exactly an object with one version key.

@marten-seemann
Copy link
Contributor

This could be part of the release-checker workflow. It could then report a malformed version.json on the PR.

@galargh
Copy link
Contributor

galargh commented Aug 28, 2023

This issue was transferred to ipdxco/unified-github-workflows#41 in preparation for archiving of this repository.

@galargh galargh closed this as completed Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants