Skip to content

protobufjs library itself doesn't provide module support #1230

Open
@gertcuykens

Description

@gertcuykens

protobuf.js version: 6.8.8
example: https://github.com/gertcuykens/protobuf

Generated modules looks ok using

pbjs -p . task.proto -t static-module -w es6 -o task.pb.mjs
import protobuf from 'protobufjs'
import {Task} from './task/task.pb.mjs'

But it seems the protobufjs library itself doesn't provide module support?

node --experimental-modules task_test.mjs 
(node:1831) ExperimentalWarning: The ESM module loader is experimental.
internal/modules/esm/default_resolve.js:69
  let url = moduleWrapResolve(specifier, parentURL);
            ^

Error: Cannot find module '/Users/gert/go/src/github.com/gertcuykens/protobuf/node_modules/protobufjs/minimal' imported from /Users/gert/go/src/github.com/gertcuykens/protobuf/task/task.pb.mjs
    at Loader.resolve [as _resolve] (internal/modules/esm/default_resolve.js:69:13)
    at Loader.resolve (internal/modules/esm/loader.js:70:33)
    at Loader.getModuleJob (internal/modules/esm/loader.js:143:40)
    at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:43:40)
    at link (internal/modules/esm/module_job.js:42:36)
gert@gert ~/go/src/github.com/gertcuykens/protobuf:master>

Suggest to make a seperate protobufjs/minimal.mjs and protobufjs/index.mjs maybe to have full module support out of the box?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions