Skip to content

Commit ae79b87

Browse files
proteamerpixelhandler
authored andcommitted
Ember Enumerable#contains is deprecated so let's use Enumerable#includes (pixelhandler#117)
* Ember Enumerable#contains is deprecated so let's use Enumerable#includes * Use ember-runtime-enumerable-includes-polyfill to fix the deprecation in a backwards-compatible way
1 parent bb3779a commit ae79b87

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

addon/models/resource.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ const Resource = Ember.Object.extend(ResourceOperationsMixin, {
215215
data.push(identifier);
216216
if (resource) {
217217
let resources = this.get(related);
218-
if (!resources.contains(resource)) {
218+
if (!resources.includes(resource)) {
219219
resources.pushObject(resource);
220220
}
221221
}

blueprints/jsonapi-initializer-test/files/tests/unit/initializers/__name__-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ test('it registers <%= resource %> factory: model, injects into: service, serial
2525
<%= classifiedModuleName %>Initializer.initialize(registry, application);
2626

2727
let registered = Ember.A(factories.mapBy('name'));
28-
assert.ok(registered.contains('model:<%= entity %>'), 'model:<%= entity %> registered');
28+
assert.ok(registered.includes('model:<%= entity %>'), 'model:<%= entity %> registered');
2929
let msg = '<%= resource %> injected into service:store';
3030
assert.equal(injections.findBy('factory', 'service:store').property, '<%= resource %>', msg);
3131
msg = 'serializer injected into service:<%= resource %>';

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
"dependencies": {
6666
"ember-cli-babel": "^5.1.7",
6767
"ember-inflector": "^1.9.1",
68+
"ember-runtime-enumerable-includes-polyfill": "^1.0.2",
6869
"inflection": "~1.7.1",
6970
"lodash": "~3.10.1"
7071
},

tests/unit/initializers/store-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ test('it registers service and injects into route and controller', function(asse
2525
initialize(registry, application);
2626

2727
let registered = Ember.A(factories.mapBy('name'));
28-
assert.ok(registered.contains('service:store'), 'service:briefs registered');
28+
assert.ok(registered.includes('service:store'), 'service:briefs registered');
2929

3030
let injection = injections.findBy('factory', 'route');
3131
assert.equal(injection.property, 'store', 'store injected into route factory');

0 commit comments

Comments
 (0)