Skip to content

[Feature] Joint rotation offset and more dynamics #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conversation

matteobettini
Copy link
Member

@matteobettini matteobettini commented Jul 12, 2024

Now you can specify the fixed angle of the joint when the joint is not allowed to rotate

The PR also introduces the following dynamics:

  • Static: no movement actions
  • Forward: just froward and backwards force in the direction of the orientation
  • Rotation: just rotation action

@matteobettini matteobettini changed the title [Feature] Joint rotation offset [Feature] Joint rotation offset and more dynamics Jul 12, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 28 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (cd7c14a) to head (2c5d5d9).

Files Patch % Lines
vmas/simulator/dynamics/forward.py 0.00% 11 Missing ⚠️
vmas/simulator/dynamics/roatation.py 0.00% 7 Missing ⚠️
vmas/simulator/dynamics/static.py 0.00% 7 Missing ⚠️
vmas/simulator/joints.py 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   88.22%   87.99%   -0.23%     
==========================================
  Files          83       86       +3     
  Lines        9688     9736      +48     
==========================================
+ Hits         8547     8567      +20     
- Misses       1141     1169      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini merged commit aa1e02a into main Jul 15, 2024
4 checks passed
@matteobettini matteobettini deleted the rowing branch July 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant