Skip to content

Commit 55d9127

Browse files
committed
RFR: Efforts to purge min/max definitions of minwindef.h
Adding NOMINMAX to be defined to all projects settings because it was not enough to include windows.h indirectly using winproof88.h, although that way finally the min/max macros were not defined and did not collide with std::min/max stuff, still IntelliSense parsed the min/max macros from minwindef.h, I was unable to track it down so purge it by adding NOMINMAX to project settings!
1 parent 000cdf2 commit 55d9127

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

CConsole/CConsole.vcxproj

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
<PrecompiledHeader>NotUsing</PrecompiledHeader>
132132
<WarningLevel>Level4</WarningLevel>
133133
<Optimization>Disabled</Optimization>
134-
<PreprocessorDefinitions>_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
134+
<PreprocessorDefinitions>NOMINMAX;_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
135135
<SmallerTypeCheck>true</SmallerTypeCheck>
136136
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
137137
<PrecompiledHeaderFile>
@@ -162,7 +162,7 @@
162162
<PrecompiledHeader>NotUsing</PrecompiledHeader>
163163
<WarningLevel>Level4</WarningLevel>
164164
<Optimization>Disabled</Optimization>
165-
<PreprocessorDefinitions>_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
165+
<PreprocessorDefinitions>NOMINMAX;_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
166166
<SmallerTypeCheck>true</SmallerTypeCheck>
167167
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
168168
<PrecompiledHeaderFile>
@@ -193,7 +193,7 @@
193193
<PrecompiledHeader>NotUsing</PrecompiledHeader>
194194
<WarningLevel>Level4</WarningLevel>
195195
<Optimization>Disabled</Optimization>
196-
<PreprocessorDefinitions>_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
196+
<PreprocessorDefinitions>NOMINMAX;_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
197197
<SmallerTypeCheck>true</SmallerTypeCheck>
198198
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
199199
<PrecompiledHeaderFile>
@@ -224,7 +224,7 @@
224224
<PrecompiledHeader>NotUsing</PrecompiledHeader>
225225
<WarningLevel>Level4</WarningLevel>
226226
<Optimization>Disabled</Optimization>
227-
<PreprocessorDefinitions>_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
227+
<PreprocessorDefinitions>NOMINMAX;_ALLOW_RTCc_IN_STL;WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
228228
<SmallerTypeCheck>true</SmallerTypeCheck>
229229
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
230230
<PrecompiledHeaderFile>
@@ -255,7 +255,7 @@
255255
<PrecompiledHeader>NotUsing</PrecompiledHeader>
256256
<WarningLevel>Level3</WarningLevel>
257257
<Optimization>MaxSpeed</Optimization>
258-
<PreprocessorDefinitions>WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
258+
<PreprocessorDefinitions>NOMINMAX;WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
259259
<SmallerTypeCheck>false</SmallerTypeCheck>
260260
<RuntimeLibrary>MultiThreaded</RuntimeLibrary>
261261
<PrecompiledHeaderFile>
@@ -290,7 +290,7 @@
290290
<PrecompiledHeader>NotUsing</PrecompiledHeader>
291291
<WarningLevel>Level3</WarningLevel>
292292
<Optimization>MaxSpeed</Optimization>
293-
<PreprocessorDefinitions>WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
293+
<PreprocessorDefinitions>NOMINMAX;WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
294294
<SmallerTypeCheck>false</SmallerTypeCheck>
295295
<RuntimeLibrary>MultiThreaded</RuntimeLibrary>
296296
<PrecompiledHeaderFile>
@@ -327,7 +327,7 @@
327327
<Optimization>MaxSpeed</Optimization>
328328
<FunctionLevelLinking>false</FunctionLevelLinking>
329329
<IntrinsicFunctions>true</IntrinsicFunctions>
330-
<PreprocessorDefinitions>WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
330+
<PreprocessorDefinitions>NOMINMAX;WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
331331
<RuntimeLibrary>MultiThreaded</RuntimeLibrary>
332332
<PrecompiledHeaderFile />
333333
<DebugInformationFormat>None</DebugInformationFormat>
@@ -352,6 +352,7 @@
352352
</ItemDefinitionGroup>
353353
<ItemGroup>
354354
<ClInclude Include="..\..\PFL\PFL\PFL.h" />
355+
<ClInclude Include="..\..\PFL\PFL\winproof88.h" />
355356
<ClInclude Include="src\CConsole.h" />
356357
</ItemGroup>
357358
<ItemGroup>

CConsole/CConsole.vcxproj.filters

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@
2424
<ClInclude Include="..\..\PFL\PFL\PFL.h">
2525
<Filter>Header Files\PFL</Filter>
2626
</ClInclude>
27+
<ClInclude Include="..\..\PFL\PFL\winproof88.h">
28+
<Filter>Header Files\PFL</Filter>
29+
</ClInclude>
2730
</ItemGroup>
2831
<ItemGroup>
2932
<ClCompile Include="src\CConsole.cpp">

0 commit comments

Comments
 (0)