Fix proc limits #340
Merged
Fix proc limits #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Bell <bbell@invoca.com>
Signed-off-by: Brandon Bell <bbell@invoca.com>
brandonbell
force-pushed
the
fix-proc-limits
branch
from
d3da817 to
240ab37
Compare
Closed
SuperQ
approved these changes
Jan 11, 2021
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
LGTM, Thanks! I found the same problem and didn't check to see if someone had already opened a bugfix. 🤦
SuperQ
added a commit
to SuperQ/process-exporter
that referenced
this pull request
Jan 11, 2021
Update to latest modules, mainly to pick up procfs v0.3.0. Fixes a parsing bug in `/proc/<pid>/limits`[0]. [0]: prometheus/procfs#340 Signed-off-by: Ben Kochie <superq@gmail.com>
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
Linux limits are uint64, not int64[0]. "unlimited" is also defined as max uint64. [0]: https://github.com/torvalds/linux/blob/7c53f6b671f4aba70ff15e1b05148b10d58c2837/include/uapi/linux/resource.h#L48-L53 Signed-off-by: Brandon Bell <bbell@invoca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regex parsing of large limits as well as changes from
int64touint64. Also adjustunlimitedto be 18446744073709551615.This was realized while trying to parse the limits of
ntpprocess on a Debian based system.#338