Skip to content

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Feb 9, 2021

  • Bump procfs to include some fixes to error messages.
  • Lower zpoolStatePaths log from Warn to Debug.
  • Add workaround for missing %w in procfs errors0.

Fixes: #1961
Fixes: #1960

Signed-off-by: Ben Kochie superq@gmail.com

@SuperQ
Copy link
Member Author

SuperQ commented Feb 9, 2021

If we can get the %w change into procfs, we can skip the strings handling.

@roidelapluie
Copy link
Member

Let's get it

@discordianfish
Copy link
Member

+1 on getting %w in procfs first instead of having the string comparison

* Bump procfs to include some fixes to error messages.
* Lower zpoolStatePaths log from Warn to Debug.

Fixes: #1961
Fixes: #1960

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ merged commit acccda9 into master Feb 12, 2021
@SuperQ SuperQ deleted the superq/more_quiet_logs branch February 12, 2021 10:17
SuperQ added a commit that referenced this pull request Feb 12, 2021
* [BUGFIX] Fix ineffassign issue #1957
* [BUGFIX] Fix some noisy log lines #1962

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Feb 12, 2021
SuperQ added a commit that referenced this pull request Feb 13, 2021
* [BUGFIX] Fix ineffassign issue #1957
* [BUGFIX] Fix some noisy log lines #1962

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Feb 13, 2021
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* [BUGFIX] Fix ineffassign issue prometheus#1957
* [BUGFIX] Fix some noisy log lines prometheus#1962

Signed-off-by: Ben Kochie <superq@gmail.com>
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
* [BUGFIX] Fix ineffassign issue prometheus#1957
* [BUGFIX] Fix some noisy log lines prometheus#1962

Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants