Update OM 2.0 with proposal#43 Created Timestamp syntax #2636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
force-pushed
the
om-created-timestamps
branch
from
ee584fd to
f24c2ab
Compare
krajorama
reviewed
May 30, 2025
krajorama
changed the title
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
ArthurSens
force-pushed
the
om-created-timestamps
branch
from
77a1036 to
8d8e083
Compare
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
krajorama
reviewed
Jun 3, 2025
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
krajorama
approved these changes
Jun 3, 2025
Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com> Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Thanks for clarifying about exemplars :) |
dashpole
reviewed
Jun 11, 2025
| acme_http_router_request_seconds_sum{path="/api/v1",method="GET"} 9036.32 ct@1605281325.0 | ||
| acme_http_router_request_seconds_count{path="/api/v1",method="GET"} 807283.0 ct@1605281325.0 | ||
| acme_http_router_request_seconds_sum{path="/api/v2",method="POST"} 479.3 ct@1605281325.0 | ||
| acme_http_router_request_seconds_count{path="/api/v2",method="POST"} 34.0 ct@1605281325.0 |
There was a problem hiding this comment.
nit: Should we make the created timestamps different in the example? IIRC, the CR is the timestamp of the first observation for the series, so they will almost never match. We don't want to give the wrong impression that they will always be the same.
| ``` | ||
|
|
||
| Exemplars MAY be attached to the MetricPoint's Total sample. | ||
|
|
||
| An example with a Metric with no labels, and a MetricPoint with a timestamp and a created and an exemplar: |
There was a problem hiding this comment.
Should this be "Created Value" or "created timestamp"
| ``` | ||
|
|
||
| An example of a Metric with no labels and a MetricPoint with two quantiles: | ||
| An example of a Metric with no labels and a MetricPoint with two quantiles and Created values: |
There was a problem hiding this comment.
Suggested change
| An example of a Metric with no labels and a MetricPoint with two quantiles and Created values: | |
| An example of a Metric with no labels and a MetricPoint with two quantiles and Created Values: |
nit: consistently capitalize or lowercase "Created Value"
| foo_count 17 | ||
| foo_sum 324789.3 | ||
| foo_created 1520430000.123 | ||
| foo_bucket{le="0.0"} 0 ct@1520430000.123 |
There was a problem hiding this comment.
Same comment about created timestamps all being different. Count and sum should match the lowest CT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates OpenMetrics 2.0 with our discussions in the working group and prometheus/proposals#43
cc @Maniktherana