Added compression support in pushgateway #1144
Open
+85
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ritesh-avesha <ritesh@aveshasystems.com>
ritesh-avesha
force-pushed
the
pushgateway-compression
branch
from
4e71a82 to
fd91251
Compare
Member
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
Thanks!
A few comments but generally excited to see this work. Plus it looks like some linters are failing.
| for k, v in sorted(grouping_key.items())) | ||
|
|
||
| data = b'' | ||
| headers = [('Content-Type', CONTENT_TYPE_PLAIN_0_0_4)] |
Member
There was a problem hiding this comment.
I don't love defining this default header in two places, perhaps append here? Or does delete even need this header as there is no content type?
Comment on lines
+758
to
+761
| try: | ||
| import snappy | ||
| except ImportError as exc: | ||
| raise RuntimeError('Snappy compression requires the python-snappy package to be installed.') from exc |
Member
There was a problem hiding this comment.
Trying an import on each request feels a bit slow, could we do this once and then have a variable for if snappy is enabled or not?
| self.assertEqual(decompressed, b'# HELP g help\n# TYPE g gauge\ng 0.0\n') | ||
|
|
||
| def test_push_with_snappy_compression(self): | ||
| snappy = pytest.importorskip('snappy') |
Member
There was a problem hiding this comment.
It would be good to add snappy to one of the test envs such as
Line 11 in 1783ca8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushgateway (version >= 1.5.0) supports gzip and snappy compression (v > 1.6.0). This helps optimizing in network constrained environments
compressionargument (gzip/snappy) topush_to_gatewayandpushadd_to_gateway@csmarchbanks