fix: use tuples instead of packaging Version #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
efiop
force-pushed
the
patch-1
branch
4 times, most recently
from
592738c to
4d90571
Compare
|
@csmarchbanks removed packaging in favor of simple tuples, i think that should be enough. |
efiop
force-pushed
the
patch-1
branch
2 times, most recently
from
212c950 to
c2011ae
Compare
efiop
commented
Sep 11, 2025
prometheus_client/utils.py
Outdated
| if not version_str: | ||
| return (0, 0, 0) | ||
| try: | ||
| return tuple(int(x) for x in version_str.split('.')) |
There was a problem hiding this comment.
I'm not sure if we have to expect some odd version here or if they are all normal and will convert to int.
efiop
force-pushed
the
patch-1
branch
3 times, most recently
from
882326f to
e0b9a60
Compare
Signed-off-by: Ruslan Kuprieiev <kupruser@gmail.com>
There was a problem hiding this comment.
Thanks! A couple things I think we should support just to be on the safe side:
- a
vprefix should be stripped off, it doesn't perfectly match the specs but seems silly to not recognize the version if it is present. - A build version, e.g. the third part has
-rc.0or something like that. Similarly, just strip it off the third part.
A test for a few different permutations of versions would be great as well
|
Just a friendly bump on my previous comments. I can also do the modifications myself if you do not have the time! |
csmarchbanks
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1135